stash/GuessRecipeVersion: Fix recipes without version#363
Merged
priv-kweihmann merged 1 commit intoFeb 24, 2026
Merged
Conversation
6 tasks
priv-kweihmann
requested changes
Feb 23, 2026
michalsieron
force-pushed
the
stash-guessrecipeversion
branch
from
0b286e0 to
f747b90
Compare
When a recipe didn't have version in its name, this function was returning its entire name instead of either an empty value or Yocto default "1.0". I changed it to return None if no version can be extracted from the file name. I also added a new test in tests/test_expand.py to check multiple scenarios of versioned/unversioned recipe files with or without PV defined in them. Signed-off-by: Michal Sieron <michalwsieron@gmail.com>
michalsieron
force-pushed
the
stash-guessrecipeversion
branch
from
f747b90 to
e5134d6
Compare
Contributor
Author
|
@priv-kweihmann I think I addressed your points in cls_stash.py. Added new test as requested with several test cases inside. |
priv-kweihmann
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a recipe didn't have version in its name, this function was returning its entire name instead of either an empty value or Yocto default "1.0".